Skip to content

fix: Fix base url regression to ensure trailing /#2990

Merged
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:fix-url-regression
Dec 19, 2025
Merged

fix: Fix base url regression to ensure trailing /#2990
stevehipwell merged 1 commit intointegrations:mainfrom
stevehipwell:fix-url-regression

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell commented Dec 9, 2025 •
edited
Loading

Resolves #2978

This is a regression introduced in #2951.

Before the change?

  • The GitHub client for the REST API can be configured with a base URL missing a trailing /
  • The base URL needed to be configured exactly right

After the change?

  • The GitHub client for the REST API base URL is configured correctly
  • The base URL configuration is more flexible

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell self-assigned this Dec 9, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 9, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-actions github-actions bot added the Type: Bug Something isn't working as documented label Dec 9, 2025
@stevehipwell stevehipwell added this to the v6.9.1 Patch milestone Dec 9, 2025
@stevehipwell
Copy link
Copy Markdown
Collaborator Author

stevehipwell commented Dec 10, 2025

@nickfloyd could you please review this PR?

@stevehipwell stevehipwell marked this pull request as draft December 11, 2025 11:52
@stevehipwell
Copy link
Copy Markdown
Collaborator Author

stevehipwell commented Dec 11, 2025

I'm refactoring this again to make it simpler.

@stevehipwell stevehipwell force-pushed the fix-url-regression branch 3 times, most recently from 2eecd3b to f616e9f Compare December 11, 2025 13:15
@stevehipwell stevehipwell marked this pull request as ready for review December 11, 2025 13:17
@stevehipwell
fix: Fix base url regression to ensure trailing /
8db0781 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell mentioned this pull request Dec 15, 2025
Closed
1 task
@stevehipwell stevehipwell merged commit c4d9e26 into integrations:main Dec 19, 2025
6 checks passed
@stevehipwell stevehipwell deleted the fix-url-regression branch December 19, 2025 15:10
This was referenced Jan 2, 2026
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

+1 more reviewer

@deiga deiga deiga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stevehipwell stevehipwell

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Milestone

v6.9.1 Patch

Development

Successfully merging this pull request may close these issues.

[BUG]: failed to create OAuth token from GitHub App

3 participants

@stevehipwell @deiga @nickfloyd