Skip to content

chore: Refactor integration tests#2986

Merged
stevehipwell merged 1 commit intomainfrom
refactor-integration-tests
Jan 6, 2026
Merged

chore: Refactor integration tests#2986
stevehipwell merged 1 commit intomainfrom
refactor-integration-tests

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell commented Dec 8, 2025 •
edited
Loading

Resolves #2983
Resolves #2984
Resolves #2985
Resolves #3006
Closes #2941

Before the change?

  • The acceptance tests are complicated and some are broken
  • Some of the code is incorrect

After the change?

  • Acceptance tests have been refactored
    • Fewer tests
    • Simpler test structure
    • Test env setup has been made more granular and documented
  • Acceptance tests have been run
    • Some tests that require paid features haven't been run yet

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@stevehipwell stevehipwell self-assigned this Dec 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 8, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from 64384d9 to a3a1145 Compare December 8, 2025 22:44
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from a3a1145 to 79637e0 Compare December 8, 2025 22:46
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from 79637e0 to 8f8da76 Compare December 8, 2025 22:47
deiga
deiga reviewed Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half-way through, looking good so far!

@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from 8f8da76 to d6872d3 Compare December 9, 2025 10:29
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from d6872d3 to b273abd Compare December 9, 2025 12:29
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from b273abd to 337b854 Compare December 9, 2025 14:28
@stevehipwell stevehipwell added the acctest For CI / automated testing label Dec 9, 2025
@stevehipwell stevehipwell added this to the v6.9.1 Patch milestone Dec 9, 2025
deiga
deiga reviewed Dec 9, 2025
View reviewed changes
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from 94d69ba to 86c88d6 Compare December 10, 2025 10:40
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from 86c88d6 to e2e13b1 Compare December 10, 2025 11:19
@stevehipwell stevehipwell force-pushed the refactor-integration-tests branch from e2e13b1 to f992480 Compare December 10, 2025 11:23
deiga
deiga reviewed Dec 10, 2025
View reviewed changes
@deiga deiga mentioned this pull request Dec 10, 2025
Merged
5 tasks
@deiga deiga mentioned this pull request Dec 17, 2025
Closed
1 task
deiga
deiga reviewed Dec 24, 2025
View reviewed changes
deiga
deiga reviewed Dec 24, 2025
View reviewed changes
deiga
deiga reviewed Dec 24, 2025
View reviewed changes
deiga
deiga reviewed Dec 24, 2025
View reviewed changes
deiga
deiga reviewed Dec 26, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@deiga deiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple tests commented out in this PR. They seem to cover functionality which isn't covered otherwise, are those just WIP refactoring or is there some other purpose?

@deiga deiga mentioned this pull request Jan 5, 2026
Merged
4 tasks
@stevehipwell
Copy link
Copy Markdown
Collaborator Author

stevehipwell commented Jan 6, 2026

@nickfloyd @deiga I think this PR is ready to be merged. All of the tests I'm able to run locally have been run and passed.

nickfloyd
nickfloyd previously approved these changes Jan 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found one super small thing! 👍

deiga
deiga approved these changes Jan 6, 2026
View reviewed changes
@stevehipwell
chore: Refactor integration tests
581b507 
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

+1 more reviewer

@deiga deiga deiga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stevehipwell stevehipwell

Labels

Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

None yet

Milestone

v6.10.0 Release

3 participants

@stevehipwell @deiga @nickfloyd