Skip to content

[BUG] Fixes boolean conversions in rulesets from causing Panics#2977

Merged
stevehipwell merged 1 commit intointegrations:mainfrom
F-Secure-web:fix-panic-on-ruleset-booleans
Dec 8, 2025
Merged

[BUG] Fixes boolean conversions in rulesets from causing Panics#2977
stevehipwell merged 1 commit intointegrations:mainfrom
F-Secure-web:fix-panic-on-ruleset-booleans

Conversation

@deiga
Copy link
Copy Markdown
Collaborator

@deiga deiga commented Dec 7, 2025

Resolves #2708 #2872 #2776


Before the change?

  • Reading rulesets might cause a Panic if expected boolean values were nil

After the change?

  • Boolean conversions should default to false if conversion failed

Pull request checklist

  • Schema migrations have been created if needed (example)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Signed-off-by: Timo Sand <timo.sand@f-secure.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 7, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-actions github-actions bot added the Type: Bug Something isn't working as documented label Dec 7, 2025
Copy link
Copy Markdown
Collaborator

@diofeher diofeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell merged commit a3b39ed into integrations:main Dec 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: State Update fails with panic on 6.6.0

3 participants