Add values_editable_by support to github_organization_custom_properties#2931
Merged
nickfloyd merged 5 commits intointegrations:mainfrom Nov 25, 2025
Merged
Conversation
79b4ec9 to
a06f75a
Compare
|
I was looking to add the same PR to fix this missing property on the provider! |
deiga
suggested changes
Nov 23, 2025
Collaborator
deiga
left a comment
There was a problem hiding this comment.
@markszabo Thank you for your contribution! 🎉
I'd like to ask you for a few more additions:
- Could you add a test that verifies that this change won't affect existing values of the
values_editable_byfield in the API? - Since the
values_editable_byfield has a specific list of values it accepts, could you add validation to check it's values? :)
Contributor
Author
|
@deiga thank you for the review, I made the requested changes. Let me know what you think :) |
mroyme
approved these changes
Nov 25, 2025
stevehipwell
approved these changes
Nov 25, 2025
Collaborator
stevehipwell
left a comment
There was a problem hiding this comment.
LGTM
@nickfloyd are you running local tests on PRs before merging them?
Member
Always. It's a bit of a slog, but it's currently the best approach for verification that we have. |
Collaborator
Hopefully #2946 will be able to make this less of a challenge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2930
Before the change?
The
github_organization_custom_propertiesresource does not support thevalues_editable_byfield. On the UI this is calledAllow repository actors to set this propertyand can be set to eitherEnabledorDisabled. In the API (and go-github) it is calledvalues_editable_byand can be set toorg_actors(default),org_and_repo_actors.After the change?
The
github_organization_custom_propertiesresource now supports thevalues_editable_byfield with valuesorg_actors(default) ororg_and_repo_actors.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
This adds a new, optional field who's default value matches the current behavior.