fix: Add INFO level logging for rate limit events#2884
fix: Add INFO level logging for rate limit events#2884pmartindev wants to merge 1 commit intointegrations:mainfrom
Conversation
Fixes integrations#1226 Previously, rate limit messages were only logged at DEBUG level, causing the provider to appear to hang without feedback when rate limited. This change adds INFO level logging that is visible by default, informing users when: - GitHub abuse detection is triggered - API rate limits are reached Users will now see messages indicating the provider is waiting and will retry, rather than appearing frozen.
|
@pmartindev have you tested this change? |
|
@stevehipwell no I haven't yet. This one will be somewhat challenging to manually test 😅 I thought we would have a discussion on if this is meets the criteria for solving the initial issue. Do we want to change how rate limits are output, or do we want to continue to only output this as debug output? I think there's an argument for both, and the solution may just be to "switch to debug mode" to validate rate limits. I'm also not sure if there is a broader discussion on if we should update from the legacy logging system https://developer.hashicorp.com/terraform/plugin/log/writing#legacy-logging |
|
@pmartindev I suspect that you wont see the logs even after your change as the default provider log configuration is none and I think this applies to the legacy pattern. |
|
@pmartindev An easy way to test this, is adding any other INFO level log or looking for where an existing INFO level log get's written and see if it shows up in the console, without setting TF_LOG |
|
And to your question: Yes, it would make sense. |
Resolves #1226
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!