feat: Adds enterprise settings resources to the provider#2852
feat: Adds enterprise settings resources to the provider#2852
Conversation
stevehipwell
left a comment
There was a problem hiding this comment.
@nickfloyd I think this resource should be broken up to be a 1-2-1 mapping between API calls and TF resources. This is the idiomatic TF pattern and puts the least pressure on the GitHub API.
Let me put together something next week and I'll cc you to make sure I address your thoughts as expected. ❤️ |
…aligns with the API resource structure
…aligns with the API resource structure
|
@nickfloyd is this still a work in progress? |
@stevehipwell I feel like it's in a pretty good spot for 👀 and feedback - I'd love to get it in if we all agree it's good to go! ❤️ |
|
@nickfloyd I only asked because it looks like you've only got tests for one of the new resources? |
Oh man! Great catch... |
stevehipwell
left a comment
There was a problem hiding this comment.
LGTM
FYI - There is a missing new line ending for the example TF file.
Resolves #1199
Before the change?
Prior to this change we were missing some enterprise settings resources in the provider
After the change?
Adds the following enterprise settings resources to the provider
✅ Read-only workflow permissions by default - Available via DefaultWorkflowPermissionEnterprise
✅ Contributor approval permissions - Available via ContributorApprovalPermissions
✅ Advanced Security - Available via EnterpriseSecurityAnalysisSettings
✅ Secret scanning - Available via EnableDisableSecurityFeature
✅ Secret scanning push protection - Available via EnableDisableSecurityFeature
✅ Self-hosted runner permissions - Available via SelfHostRunnerPermissionsEnterprise
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!