Skip to content

fix/feature: Adds support for max_file_size, max_file_path_length, file_extension_restriction, and unknown rulesets for repos and orgs#2821

Merged
nickfloyd merged 11 commits intomainfrom
support-unsupported-rulsets
Oct 27, 2025
Merged

fix/feature: Adds support for max_file_size, max_file_path_length, file_extension_restriction, and unknown rulesets for repos and orgs#2821
nickfloyd merged 11 commits intomainfrom
support-unsupported-rulsets

Conversation

@nickfloyd
Copy link
Copy Markdown
Member

@nickfloyd nickfloyd commented Oct 27, 2025 •
edited
Loading

Resolves #2818
Resolves #2737
Resolves #2714
Resolves #2394
Resolves #2597

Before the change?

  • When the provider encountered an unsupported ruleset the plain would fail and when apply was executed the plan would show no changes

After the change?

  • Added: Complete push ruleset support for org:
    • file_path_restriction
    • max_file_size
    • max_file_path_length
    • file_extension_restriction
  • Added: push target support (alongside existing branch and tag)
  • Added: max_file_path_length rule support for repos

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd self-assigned this Oct 27, 2025
@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Oct 27, 2025
@nickfloyd nickfloyd moved this from Backlog to In Review in Terraform Provider Oct 27, 2025
@nickfloyd nickfloyd changed the title fix: Adds support for max_file_size and file_extension_restriction and default rulesets fix: Adds support for max_file_size, max_file_path_length, file_extension_restriction, and unknown rulesets Oct 27, 2025
@nickfloyd nickfloyd changed the title fix: Adds support for max_file_size, max_file_path_length, file_extension_restriction, and unknown rulesets fix: Adds support for max_file_size, max_file_path_length, file_extension_restriction, and unknown rulesets for repos and orgs Oct 27, 2025
@nickfloyd nickfloyd changed the title fix: Adds support for max_file_size, max_file_path_length, file_extension_restriction, and unknown rulesets for repos and orgs fix/feature: Adds support for max_file_size, max_file_path_length, file_extension_restriction, and unknown rulesets for repos and orgs Oct 27, 2025
@nickfloyd nickfloyd added the Type: Feature New feature or request label Oct 27, 2025
@nickfloyd nickfloyd merged commit 1b1cdcd into main Oct 27, 2025
3 checks passed
@nickfloyd nickfloyd deleted the support-unsupported-rulsets branch October 27, 2025 20:38
@github-project-automation github-project-automation bot moved this from In Review to Done in Terraform Provider Oct 27, 2025
@mikutas mikutas mentioned this pull request Nov 7, 2025
Closed
1 task
@aaronscofield
Copy link
Copy Markdown

aaronscofield commented Nov 12, 2025

Hi, @nickfloyd, any estimate on when the next release including these changes will be created?

@nickfloyd
Copy link
Copy Markdown
Member Author

nickfloyd commented Nov 12, 2025

Hi, @nickfloyd, any estimate on when the next release including these changes will be created?

Just did one about an hour ago 😉 https://github.com/integrations/terraform-provider-github/releases/tag/v6.8.0

@neptune19821220 neptune19821220 mentioned this pull request Nov 13, 2025
Closed
1 task
@stevehipwell stevehipwell mentioned this pull request Nov 13, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hypercycle hypercycle hypercycle approved these changes

@stevehipwell stevehipwell Awaiting requested review from stevehipwell

Assignees

@nickfloyd nickfloyd

Labels

Type: Bug Something isn't working as documented Type: Feature New feature or request

Projects

Terraform Provider
Status: Done

Milestone

No milestone

3 participants

@nickfloyd @aaronscofield @hypercycle