Skip to content

fix: make repository argument required#2603

Merged
diofeher merged 3 commits intointegrations:mainfrom
mikutas:2561
Nov 27, 2025
Merged

fix: make repository argument required#2603
diofeher merged 3 commits intointegrations:mainfrom
mikutas:2561

Conversation

@mikutas
Copy link
Copy Markdown
Contributor

@mikutas mikutas commented Mar 25, 2025

Resolves #2561


Before the change?

  • terraform plan successes without repository argument, but terraform apply fails.

After the change?

  • terraform plan fails without repository argument.
    • image

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@mikutas mikutas marked this pull request as ready for review March 26, 2025 06:57
@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
Copy link
Copy Markdown
Contributor

@vedantthapa vedantthapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! While you're at it, would you also mind applying the typo fix?

mikutas and others added 2 commits October 6, 2025 11:42
Co-authored-by: Vedant Thapa <43611693+vedantthapa@users.noreply.github.com>
Co-authored-by: Vedant Thapa <43611693+vedantthapa@users.noreply.github.com>
@mikutas mikutas requested a review from vedantthapa October 6, 2025 02:43
Copy link
Copy Markdown
Contributor

@vedantthapa vedantthapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm not a maintainer though :)

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Nov 27, 2025

Thank you for contributing this!

We'll look into getting this approved! ☺️

Copy link
Copy Markdown
Collaborator

@diofeher diofeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution @mikutas !

@diofeher diofeher merged commit f9b0678 into integrations:main Nov 27, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🧰 Octokit Active Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: github_repository_ruleset repository is optional

6 participants