Skip to content

correct grammar errors in data.github_release docs#2515

Merged
stevehipwell merged 2 commits intointegrations:mainfrom
mdb:mdb/grammar-fixes
Dec 19, 2025
Merged

correct grammar errors in data.github_release docs#2515
stevehipwell merged 2 commits intointegrations:mainfrom
mdb:mdb/grammar-fixes

Conversation

@mdb
Copy link
Copy Markdown
Contributor

@mdb mdb commented Dec 14, 2024

This corrects grammar errors in the github_release data source documentation by correcting the contraction "it's" ("it is") to the possessive "its."


Before the change?

After the change?

Pull request checklist

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

No


@mdb mdb marked this pull request as ready for review December 14, 2024 12:07
@mdb
Copy link
Copy Markdown
Contributor Author

mdb commented May 4, 2025

@lafrenierejm - I see you've approved this back in February. Do you have any sense of if/when it can be merge and released?

@lafrenierejm
Copy link
Copy Markdown

I see you've approved this back in February. Do you have any sense of if/when it can be merge and released?

@mdb Unfortunately I do not. My approval was simply as a community member. I'm not a maintainer of this project and don't have any private insight into the PR review process.

@mdb
Copy link
Copy Markdown
Contributor Author

mdb commented May 5, 2025

Hi @kfcampbell - I believe you've merged/released other PRs. Is there anything I can do to help steward this along to get it reviewed, merged, and released? Thanks!

@deiga
Copy link
Copy Markdown
Collaborator

deiga commented Dec 17, 2025

Hey @mdb 👋

Thank you for your contribution!
Would you be available to update the Description fields of this data source? We are planning to upgrade to an more automated system, which uses the Description fields to generate the docs

mdb added 2 commits December 17, 2025 15:38
This corrects grammar errors in the `github_release` data source
documentation by correcting the contraction "it's" ("it is") to the
possessive "its."

Signed-off-by: Mike Ball <mikedball@gmail.com>
This adds `Description` fields to the release data source, per request of @deiga
via integrations#2515 (comment)

Signed-off-by: Mike Ball <mikedball@gmail.com>
@mdb mdb force-pushed the mdb/grammar-fixes branch from 5937572 to 9ff3461 Compare December 17, 2025 20:50
@mdb
Copy link
Copy Markdown
Contributor Author

mdb commented Dec 18, 2025

@deiga Thanks! I pushed a change adding Description fields, although I don't believe the original grammar corrections in this PR necessarily clearly map to Description fields; they correct grammar associated with the docs' examples. What do you think?

@stevehipwell stevehipwell added the Type: Documentation Improvements or additions to documentation label Dec 18, 2025
@stevehipwell stevehipwell added this to the v6.9.1 Patch milestone Dec 18, 2025
Copy link
Copy Markdown
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevehipwell stevehipwell merged commit fd72b8a into integrations:main Dec 19, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🧰 Octokit Active Dec 19, 2025
@mdb mdb deleted the mdb/grammar-fixes branch December 19, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants