chore: Updated automation to support PR acceptance tests#2511
chore: Updated automation to support PR acceptance tests#2511stevehipwell wants to merge 1 commit intointegrations:mainfrom
Conversation
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
|
👋 Hey Friends, this pull request has been automatically marked as |
|
/not-stale |
deiga
left a comment
There was a problem hiding this comment.
This is looking quite good! What would it take to get this finished?
| GITHUB_TEST_EXTERNAL_USER_TOKEN: "" | ||
| GITHUB_TEST_EXTERNAL_USER2: "" | ||
| GITHUB_TEST_ADVANCED_SECURITY: "true" | ||
| run: go test -run "^TestAcc*" ./github -v -race -coverprofile=coverage.txt -covermode=atomic -sweep=tf-acc- -timeout 120m -count=1 |
There was a problem hiding this comment.
question: Since this produces a coverage.txt would we benefit from uploading the artifact?
There was a problem hiding this comment.
Yes I think so and/or integrating with a service to manage coverage.
@deiga this PR was intended to be a followup to #2476 as it only works if the tests are all actually passing. Before the PR freeze both of these PRs were working correctly and all of the tests were passing, but given the number of PRs merged since then I suspect that there may be quite a lot of changes required. I was planning on looking through the PRs and starting by taking all of the test fixes out into a new smaller and less contentious PR. The main problem here is time, both the lack of it on my side and the passage of it since I did this work that means remembering and validating the changes is going to be tricky. |
|
This PR has been replaced by #2946. |
Related to #2425
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!