Skip to content

chore: Deprecated classic project resources#2506

Merged
nickfloyd merged 2 commits intointegrations:mainfrom
stevehipwell:deprecate-classic-projects
Oct 21, 2025
Merged

chore: Deprecated classic project resources#2506
nickfloyd merged 2 commits intointegrations:mainfrom
stevehipwell:deprecate-classic-projects

Conversation

@stevehipwell
Copy link
Copy Markdown
Collaborator

Resolves #2494


Before the change?

  • Resources using the removed classic projects REST API would not work and were not deprecated

After the change?

  • Resources using the removed classic projects REST API are deprecated

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@0x46616c6b
Copy link
Copy Markdown
Contributor

In the meantime, the go-github SDK removed the (classic) projects API: https://github.com/google/go-github/releases/tag/v68.0.0

So maybe this could be removed entirely now?

@stevehipwell
Copy link
Copy Markdown
Collaborator Author

@0x46616c6b the intention here is/was to deprecate before removal as should have happened when the API was originally deprecated. Technically they were broken before I opened #2494 and should just be removed as their presence will block upgrading the SDK; but if a release is going out before the SDK is upgraded this PR is still valid. IMHO this PR should have been prioritised as it could have gone out in v6.5.0 or v6.6.0.

@stevehipwell stevehipwell force-pushed the deprecate-classic-projects branch from 38dca16 to 733c87d Compare June 3, 2025 13:14
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
@stevehipwell stevehipwell force-pushed the deprecate-classic-projects branch from 733c87d to e4991f3 Compare October 20, 2025 17:28
@stevehipwell
Copy link
Copy Markdown
Collaborator Author

@nickfloyd IMHO this should go into the codebase before the SDK is updated even if the SDK is updated and the files are removed before the next release.

@nickfloyd nickfloyd moved this from Backlog to In Progress in Terraform Provider Oct 21, 2025
@nickfloyd
Copy link
Copy Markdown
Member

@nickfloyd IMHO this should go into the codebase before the SDK is updated even if the SDK is updated and the files are removed before the next release.

Agreed. I was sketching out what transitioning to the new project endpoints in GraphQL would look like and it's going to be a fairly significant change, let alone moving to the SDK @ v76. This type of comms is way over due. Thank you for making it happen ❤️

@nickfloyd nickfloyd merged commit ca3d01c into integrations:main Oct 21, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Terraform Provider Oct 21, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🧰 Octokit Active Oct 21, 2025
@stevehipwell stevehipwell deleted the deprecate-classic-projects branch October 22, 2025 09:10
@stevehipwell
Copy link
Copy Markdown
Collaborator Author

@nickfloyd there is a REST API for projects now.

https://docs.github.com/en/rest/projects/projects?apiVersion=2022-11-28

@nickfloyd
Copy link
Copy Markdown
Member

@nickfloyd there is a REST API for projects now.

🤦 You're right. Thank you for reminding me. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[BUG]: Resources using the removed legacy projects API are still present and not deprecated in the provider

3 participants