chore: Deprecated classic project resources#2506
chore: Deprecated classic project resources#2506nickfloyd merged 2 commits intointegrations:mainfrom
Conversation
|
In the meantime, the go-github SDK removed the (classic) projects API: https://github.com/google/go-github/releases/tag/v68.0.0 So maybe this could be removed entirely now? |
|
@0x46616c6b the intention here is/was to deprecate before removal as should have happened when the API was originally deprecated. Technically they were broken before I opened #2494 and should just be removed as their presence will block upgrading the SDK; but if a release is going out before the SDK is upgraded this PR is still valid. IMHO this PR should have been prioritised as it could have gone out in |
38dca16 to
733c87d
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
733c87d to
e4991f3
Compare
|
@nickfloyd IMHO this should go into the codebase before the SDK is updated even if the SDK is updated and the files are removed before the next release. |
Agreed. I was sketching out what transitioning to the new project endpoints in GraphQL would look like and it's going to be a fairly significant change, let alone moving to the SDK @ v76. This type of comms is way over due. Thank you for making it happen ❤️ |
|
@nickfloyd there is a REST API for projects now. https://docs.github.com/en/rest/projects/projects?apiVersion=2022-11-28 |
🤦 You're right. Thank you for reminding me. ❤️ |
Resolves #2494
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!