feat: allow users to set GitHub app in their repositories#2469
feat: allow users to set GitHub app in their repositories#2469stevehipwell merged 3 commits intointegrations:mainfrom
Conversation
|
Hey @M0NsTeRRR, I might be missing it - if you get the chance could you remind me why this is a breaking change - it looks like you've just extended the functionally to now cover cases of user installed apps while still allowing for orgs as well. I just want to be sure before I merge this in. ❤️ |
|
Hey @nickfloyd !
It's exactly my use case so for me no breaking change there :) Edit : My bad I didn't see I've checked the checkbox for breaking change ... I understand why you tagged it as breaking change ! |
29b7f83 to
905a784
Compare
Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>
905a784 to
2a3e0b0
Compare
|
Hey @nickfloyd, maybe I wasn’t clear this can be scheduled before a breaking release. I accidentally checked the wrong box when creating the PR :( |
|
@M0NsTeRRR could you please rebase this PR? |
stevehipwell
left a comment
There was a problem hiding this comment.
LGTM
CC @nickfloyd
Resolves #2468
Before the change?
github_app_installation_repositoryandgithub_app_installation_repositoriescurrently looks for an organization and deny users.After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!