fix: do not update/create rulesets on archived repository#2460
Merged
diofeher merged 12 commits intointegrations:mainfrom Dec 2, 2025
Merged
fix: do not update/create rulesets on archived repository#2460diofeher merged 12 commits intointegrations:mainfrom
diofeher merged 12 commits intointegrations:mainfrom
Conversation
At the moment, provider would attempt to update `github_repository_ruleset` on archived repository resulting in 403 from GitHub API. Provider should not attempt updating this attribute when repository is archived (read-only).
Collaborator
|
Hey @scadu 👋 Would you be available to resolve the merge conflicts on this PR? Then we can try to get this reviewed and merged |
dfda867 to
b4f0310
Compare
083161c to
79b52cb
Compare
Contributor
Author
diofeher
reviewed
Dec 1, 2025
Collaborator
|
There are a few lint errors here: https://github.com/integrations/terraform-provider-github/actions/runs/19816483287/job/56804316636?pr=2460 |
ee5f84c to
27ce6ee
Compare
diofeher
reviewed
Dec 1, 2025
77ad2ce to
964e7d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, provider would attempt to update
github_repository_ruleseton archived repository resulting in 403 from GitHub API. Provider should not attempt updating this attribute when repository is archived (read-only).Resolves #2459
Before the change?
github_repository_ruleseton archived (read-only) repository.After the change?
github_repository_ruleseton archived repository.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!