chore: update go-github to V65#2359
Conversation
ff8e06e to
2be7b99
Compare
Co-authored-by: Ze Peng <zehui.peng@circle.com>
go.mod
Outdated
| github.com/go-jose/go-jose/v3 v3.0.3 | ||
| github.com/golangci/golangci-lint v1.59.1 | ||
| github.com/google/go-github/v63 v63.0.0 | ||
| github.com/google/go-github/v64 v64.0.0 |
There was a problem hiding this comment.
we need to bump this to v65 and remove the indirect below, running go mod tidy should then also remove v64 from go.sum
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry I was rushing and missed this step, done now
|
@kfcampbell @nickfloyd (sorry just tagging some maintainers who recently approved PRs) can we get some eyes on this PR please. It helps unblock couple other PRs that is currently blocked requiring newer version of google/go-github |
|
@grahamhar @kfcampbell @nickfloyd This is has been open for over a month and blocking a few other PRs now, possible to have this merged or taken over by someone with bandwidth to do so? |
Apologies for the delay. I'm looking at this today and should have it merged in and shipped. |
kfcampbell
left a comment
There was a problem hiding this comment.
I have attempted to run the checklist but some changes are being flagged in plan due to dependabot being enabled by default on the org in use. Is this due to the way new orgs have vulnerability_alerts on by default now for public repositories?
Example of failing test.
@grahamhar unfortunately this failure has crept into our main branch and will need to be dealt with separately. Fortunately for this case, this means we can take this PR as-is now.
As always, thank you for your attention to the testing in this provider.
Resolves #2358
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
I have attempted to run the checklist but some changes are being flagged in plan due to dependabot being enabled by default on the org in use. Is this due to the way new orgs have vulnerability_alerts on by default now for public repositories?
Example of failing test.
RUN TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_organization_account data_source_github_repository_file_test.go:166: Step 1/1 error: After applying this test step, the plan was not empty. stdout: Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place <= read (data resources) Terraform will perform the following actions: # data.github_repository_file.test will be read during apply # (depends on a resource or a module with changes pending) <= data "github_repository_file" "test" { + commit_author = (known after apply) + commit_email = (known after apply) + commit_message = (known after apply) + commit_sha = (known after apply) + content = (known after apply) + file = "test" + id = (known after apply) + ref = (known after apply) + repository = "tf-acc-test-2ly8t" + sha = (known after apply) } # github_repository.test will be updated in-place ~ resource "github_repository" "test" { id = "tf-acc-test-2ly8t" name = "tf-acc-test-2ly8t" - vulnerability_alerts = true -> null # (32 unchanged attributes hidden) # (1 unchanged block hidden) } Plan: 0 to add, 1 to change, 0 to destroy. --- FAIL: TestAccGithubRepositoryFileDataSource (28.72s) --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided (11.38s) --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided/with_an_individual_account (0.00s) --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_with_a_branch_name_provided/with_an_organization_account (11.38s) --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name (17.35s) --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_individual_account (0.00s) --- FAIL: TestAccGithubRepositoryFileDataSource/create_and_read_a_file_without_providing_a_branch_name/with_an_organization_account (17.34s) FAIL FAIL github.com/integrations/terraform-provider-github/v6/github 29.802s FAIL