Fix typo in org rulesets.repository_id#1884
Merged
nickfloyd merged 2 commits intointegrations:mainfrom Sep 11, 2023
Merged
Conversation
2 tasks
timja
approved these changes
Sep 11, 2023
Contributor
Author
|
BTW, @kfcampbell, if we do release a patch as is and break the use of |
nickfloyd
approved these changes
Sep 11, 2023
Member
nickfloyd
left a comment
There was a problem hiding this comment.
Thank you for the correction here. We'll drop a major version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change?
A typo was introduced when this feature was added in #1808.
repository_organization_ruleset.conditions.repository_idhas fieldinlcude.After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
The breaking change is in the organization ruleset resource, a field name is being changed so users must reference the new name to move to the new version of the provider once this is released. @kfcampbell let me know if you'd like me to instead support two versions of the field, it's doable but in my opinion there hasn't been much time to adopt this feature and so we should release a patch instead. I'll be ready to add support for both either way.