-
Notifications
You must be signed in to change notification settings - Fork 915
feat: Add allow_forking to github_repository #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add allow_forking to github_repository #1649
Conversation
a5857fe to
793acb5
Compare
|
Thank you @pascal-hofmann! Do you mind helping me run these tests? They're passing for me on the main branch but failing on this branch with a Does it pass for you? |
|
@kfcampbell No, it does not. :( No idea what's wrong here… |
|
Any chance of getting this merged? |
|
is it forgotten? |
793acb5 to
9756290
Compare
|
I've just rebased this PR and resolved the conflicts. |
|
Is there anything it can be done to push this forward? In highly automated environments as ours, and trying to push innersourcing internally, this is a bump on the road. Let us know if there's something we can do to help you on this. Thanks! 🙏 |
|
Hey, what is blocking this PR? We'd love to have it. |
|
Is this something that will be resolved soon? We are having to work around not having this attribute available in Terraform |
|
@pascal-hofmann, please resolve the conflicts, then @kfcampbell, please look at this. |
9756290 to
41a05a6
Compare
|
@kfcampbell Seems like the tests work this time. |
|
Any ETA when it can be merged? |
|
Any idea when it will be possible to merge it? |
|
It would be very helpful for us also. Is there are any updates regarding ETA? |
|
+1 |
|
@pascal-hofmann please let us know when this can me merged?? |
41a05a6 to
98535de
Compare
|
I just rebased once more. @kfcampbell can you review/merge? @chiradeepsai I'm just an outside contributor without the power to merge. :( |
|
This has been lingering for way too long, it would be great to understand what exactly is the reason not to include this if the provider maintainers are not merging it in for a particular reason. |
|
@silabs-DylanW In a different project I once had a patch rejected after waiting 12 1/2 years. 😅 |
- Add allow_forking schema field (optional, no default) - Implement conditional logic to only set allow_forking for non-public repos - Add conditional read to only store allow_forking in state for non-public repos - Add comprehensive acceptance tests with skipUnlessMode helper - Update existing repository tests to include allow_forking Fixes integrations#353
98535de to
8e4bf1c
Compare
|
@pmartindev Looking at the history of See #1136. Converting to draft for now. |
|
Hey @pascal-hofmann 👋 Thank you very much for your contribution! We've recently added more maintainers to the project and hope to get everything merged Now, I don't have merge permissions, but I'll be coordinating some of the efforts. Would you be available to rebase and resolve conflicts, yet again 😬? I also wonder if this needs any additional tests or changes for enterprises that disallow forking? |
|
Hi @deiga , Cheers, |

Resolves #1071
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking changelabel)false(this is also the default stated in the REST API docs.Pull request type
Type: Feature