Skip to content

Deprecate and then remove has_downloads attribute on github_repository #966

@jtgrohn

Description

@jtgrohn

Affected Resource(s)

  • github_repository

I think github_repository should not have a has_downloads attribute since it appears to be a deprecated property. The API still returns it, but it does not allow the value to be changed https://docs.github.com/en/rest/reference/repos#update-a-repository. I suspect the backend just throws that value out. Since it appears it isn't used, it should be deprecated and/or removed from the resource since its presence is misleading. I realize full removal is a breaking change, so maybe deprecation is the way to go for now?

I cannot find an announcement or release notes about this property to fully confirm.

Metadata

Metadata

Assignees

No one assigned

    Labels

    DeprecationStatus: Needs infoFull requirements are not yet known, so implementation should not be startedStatus: StaleUsed by stalebot to clean houseType: SupportAny questions, information, or general needs around the SDK or GitHub APIsr/repository

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions