-
Notifications
You must be signed in to change notification settings - Fork 949
[MAINT]: actor_id for OrganizationAdmin seems to have changed from 1 to 0 #2536
Copy link
Copy link
Closed
Labels
Status: TriageThis is being looked at and prioritizedThis is being looked at and prioritizedType: MaintenanceAny dependency, housekeeping, and clean up Issue or PRAny dependency, housekeeping, and clean up Issue or PR
Description
Describe the need
Since a couple of days I'm getting changes shown on terraform plan related to rulesets that use the actor_type OrganizationAdmin in the bypass actors.
For example:
...
~ bypass_actors {
~ actor_id = 0 -> 1
# (2 unchanged attributes hidden)
}
# (7 unchanged blocks hidden)
}
Plan: 0 to add, 110 to change, 0 to destroy.
It seems the actor_id used internally in Github for OrganizationAdmin changed from 1 to 0.
Changing my configurations from 1 to 0 again leads to "no changes" detected as expected.
Applying with the 1 still present did not lead to any errors, so I would assume this is not a breaking change related to creating/updating this kind of resources.
I guess for this project the main impact would be that the documentation would need to be updated to refer to 0 instead of 1.
SDK Version
No response
API Version
No response
Relevant log output
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Status: TriageThis is being looked at and prioritizedThis is being looked at and prioritizedType: MaintenanceAny dependency, housekeeping, and clean up Issue or PRAny dependency, housekeeping, and clean up Issue or PR
Type
Projects
Status
✅ Done
Status
Done