-
Notifications
You must be signed in to change notification settings - Fork 949
Upgrading provider version causes a terraform plan on merge commit message/title #1295
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
Status: StaleUsed by stalebot to clean houseUsed by stalebot to clean houseStatus: Up for grabsIssues that are ready to be worked on by anyoneIssues that are ready to be worked on by anyoneType: BugSomething isn't working as documentedSomething isn't working as documentedhacktoberfestIssues for participation in HacktoberfestIssues for participation in Hacktoberfest
Description
Opening an issue on behalf of @danielpops and @chaosaffe from discussion in #1263. This would have began as of v4.31.0.
This PR causes a plan like so to be generated on repositories:
# github_repository.repo["the_repo"] will be updated in-place
~ resource "github_repository" "repo" {
id = "the_repo"
+ merge_commit_message = "PR_TITLE"
+ merge_commit_title = "MERGE_MESSAGE"
name = "the_repo"
+ squash_merge_commit_message = "COMMIT_MESSAGES"
+ squash_merge_commit_title = "COMMIT_OR_PR_TITLE"
# (28 unchanged attributes hidden)
}
Presumably this plan may confuse users since it says something is going to happen, however the changes are simply setting new defaults and they are safe to apply.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Status: StaleUsed by stalebot to clean houseUsed by stalebot to clean houseStatus: Up for grabsIssues that are ready to be worked on by anyoneIssues that are ready to be worked on by anyoneType: BugSomething isn't working as documentedSomething isn't working as documentedhacktoberfestIssues for participation in HacktoberfestIssues for participation in Hacktoberfest
Type
Projects
Status
✅ Done