Skip to content

Conversation

@kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented May 9, 2025

@kirrg001 kirrg001 requested a review from a team as a code owner May 9, 2025 14:20
@abhilash-sivan
Copy link
Contributor

suggestion:

The commit message is a bit confusing - we're actually reducing warn logs by adopting the new -- syntax.

Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current commit message is a bit unclear. Consider something like:

chore: updated watch mode configuration to eliminate warnings in npm v11

or something similiar

Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qs: Should we update this as well? Currently, we're checking for --watch, so there won't be any warnings (see), but it might be good to update this for consistency if needed.

@kirrg001
Copy link
Contributor Author

qs: Should we update this as well? Currently, we're checking for --watch, so there won't be any warnings (see), but it might be good to update this for consistency if needed.

No this is the input argument for our test script.

@kirrg001 kirrg001 merged commit be90513 into main May 14, 2025
1 check was pending
@instanacd instanacd deleted the chore-npmv11 branch July 14, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants