Skip to content

Bump pipenv, remove Python 3.8, add Python 3.13 #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aandergr merged 5 commits into from
Oct 26, 2024
Merged

Bump pipenv, remove Python 3.8, add Python 3.13 #2413

aandergr merged 5 commits into from
Oct 26, 2024

Conversation

@tinyboxvk
Copy link
Contributor

@tinyboxvk tinyboxvk commented Oct 24, 2024

Python 3.8 is EOL. This PR removes it from lint.yml and add in 3.13.

Bumping pipenv to the latest version to support 3.13.

@aandergr
Copy link
Member

aandergr commented Oct 26, 2024

Thanks!

Could you rebase this to upcoming/v4.14?

Also, in setup.py there is a check that the python version is at least 3.8, a python_requires field, and a list of supported versions as trove classifiers. Could you update them as well?

@tinyboxvk tinyboxvk changed the base branch from master to upcoming/v4.14 October 26, 2024 19:50
@tinyboxvk
Copy link
Contributor Author

tinyboxvk commented Oct 26, 2024

Could you rebase this to upcoming/v4.14?

Also, in setup.py there is a check that the python version is at least 3.8, a python_requires field, and a list of supported versions as trove classifiers. Could you update them as well?

Done.

aandergr
aandergr reviewed Oct 26, 2024
View reviewed changes
@tinyboxvk @aandergr
Update setup.py
086ce34 
Co-authored-by: Alexander Graf <17130992+aandergr@users.noreply.github.com>
@aandergr aandergr merged commit fe9c8e1 into instaloader:upcoming/v4.14 Oct 26, 2024
@aandergr
Copy link
Member

aandergr commented Oct 26, 2024

Thanks!

@tinyboxvk tinyboxvk deleted the patch-2 branch October 26, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aandergr aandergr aandergr left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tinyboxvk @aandergr