timeseries2velocity: add --polyline option#999
Merged
yunjunz merged 3 commits intoinsarlab:mainfrom May 5, 2023
Merged
Conversation
+ utils.time_func: construct design matrix for polyline fitting with manually specified starting date for each additional line segment + utils.arg_utils: - add_timefunc_argument(): add --polyline option - add_figure_argument(): add --cbar-ticks option for accurate control on the colorbar tick positions. + timeseries2velocity: - model2hdf5_dataset(): support polyline function and save the total/cumulative velocity for each polyline segments for easy visualization and interpretation. - check input --polynomial and --polyline options + cli.timeseries2velocity: add example usage Other changes not relevant to --polyline: + utils.ptime: - date_list2tbase(): add `ref_date` arg - date_list2vector: add `seconds` arg + simulation.iono.lalo_ground2iono(): more comments + tsview: printout msg minor adjustment - remove redundant print cmd. Now the tsview cmd msg will always be printed out. - always printout the save fig/txt file info, as it's very informative + objects.gps: change the default folder to store the site list file from `./` to `./GPS`.
Contributor
|
@yunjunz, thanks for the PR. Yes I will take a look. |
yuankailiu
approved these changes
May 4, 2023
Contributor
yuankailiu
left a comment
There was a problem hiding this comment.
Thank you. I think it looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR add the
timeseries2velocity.py --polylineoption (and fortsview.pyas well). Given one or multiple dates, this option will estimate an additional linear slope starting from the specified date, to catch the linear velocity change of a time-series. The result is saved in the velocity.h5 file as a dataset namedvelocityPost{YYYYMMDD}, which is the linear velocity during this segment time period, i.e. the sum of the velocity for the entire period (from the regular polynomial fitting), plus all the additional velocity change before & during the current segment periods.Detailed changes are as below:
utils.time_func: construct a design matrix for polyline fitting with the manually specified starting date for each additional line segmentutils.arg_utils.add_timefunc_argument(): add--polylineoptiontimeseries2velocity:model2hdf5_dataset(): support the polyline function and save the total/cumulative velocity for each polyline segment for easy visualization and interpretation.--polynomialand--polylineoptionscli.timeseries2velocity: add example usage@yuankailiu I would appreciate it if you could take a look at these changes above when you got a chance?
Other changes not relevant to
--polyline:utils.ptime:date_list2tbase(): addref_dateargdate_list2vector(): addsecondsargutils.arg_utils.add_figure_argument(): add--cbar-ticksoption for accurate control on the colorbar tick positions.simulation.iono.lalo_ground2iono(): more commentstsview: printout msg minor adjustmentobjects.gps: change the default folder to store the site list file from./to./GPS.Reminders