resample: refactor default output step size calculation#997
Merged
yunjunz merged 1 commit intoinsarlab:mainfrom Apr 25, 2023
Merged
resample: refactor default output step size calculation#997yunjunz merged 1 commit intoinsarlab:mainfrom
yunjunz merged 1 commit intoinsarlab:mainfrom
Conversation
+ rename utils.utils0.auto_lat_lon_step_size() to objects.resample.resample.get_lat_lon_step() - move the location because this function is only used in the resample code so far - add the input lalo_step code body into this function, for a more simple code in the workflow - replace try/except with if/else and explicit required metadata checking and warning msg + objects.resample.resample.prepare_geometry_definition_radar.find_valid_lat_lon(): - rename mark_lat_lon_anomaly() to find_valid_lat_lon() - add more comments on the input/output args + cli.geocode: set default fillValue to zero for .int/unw files, to be consistent with isce/roipac. + docs/api/module_hierarchy.md: update for objects.resample.py + objects.progress.FileProgressObject(): display in int MB to be simple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
rename utils.utils0.auto_lat_lon_step_size() to objects.resample.resample.get_lat_lon_step()
prepare_geometry_definition_radar()objects.resample.resample.prepare_geometry_definition_radar.find_valid_lat_lon():
cli.geocode: set default fillValue to zero for .int/unw files, to be consistent with isce/roipac.
docs/api/module_hierarchy.md: update for objects.resample.py
objects.progress.FileProgressObject(): display in int MB to be simple
Reminders