Skip to content

simpify obj input args for tsview/plot_tran*/plot_coh*_mat*#982

Merged
yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz:plot
Mar 18, 2023
Merged

simpify obj input args for tsview/plot_tran*/plot_coh*_mat*#982
yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz:plot

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Mar 18, 2023

Description of proposed changes

Simplify the input arguments for object initiation for tsview, plot_transection and plot_coherence_matrix:

  • for each *Viewer object init(): replace cmd/iargs with inps, as the later covers both, and simpler.

  • for each *Viewer configure(): rename to open() for simplicity

Reminders

yunjunz added 2 commits March 18, 2023 15:03
+ for each *Viewer object __init__(): replace cmd/iargs with inps, as the later covers both, and simpler.

+ for each *Viewer configure(): rename to open() for simplicity
@yunjunz yunjunz changed the title simpify obj input args for tsview/plot_tran*/plot_coh*_mat* simpify obj input args for tsview/plot_tran*/plot_coh*_mat* Mar 18, 2023
@yunjunz yunjunz merged commit 386ff9b into insarlab:main Mar 18, 2023
@yunjunz yunjunz deleted the plot branch March 18, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tsview notebook example error missing required inps in v1.5.1

1 participant