simpify obj input args for tsview/plot_tran*/plot_coh*_mat*#982
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Mar 18, 2023
Merged
simpify obj input args for tsview/plot_tran*/plot_coh*_mat*#982yunjunz merged 2 commits intoinsarlab:mainfrom
tsview/plot_tran*/plot_coh*_mat*#982yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
+ for each *Viewer object __init__(): replace cmd/iargs with inps, as the later covers both, and simpler. + for each *Viewer configure(): rename to open() for simplicity
tsview/plot_tran*/plot_coh*_mat*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Simplify the input arguments for object initiation for
tsview, plot_transection and plot_coherence_matrix:for each *Viewer object init(): replace cmd/iargs with inps, as the later covers both, and simpler.
for each *Viewer configure(): rename to open() for simplicity
Reminders
missing required inpsin v1.5.1 #977