timeseries_rms: bugfix for run_or_skip and *RMS.deramp = no#970
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Mar 7, 2023
Merged
timeseries_rms: bugfix for run_or_skip and *RMS.deramp = no#970yunjunz merged 2 commits intoinsarlab:mainfrom
run_or_skip and *RMS.deramp = no#970yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
+ utils.utils1.get_residual_std/rms(): - always check the time info using the residual file for run_or_skip, instead of using the deramped residual file, as the former makes more sense. - treat the empty/false-value `ramp_type` same as `no` value, while determining the output file name from `mintpy.residualRMS.deramp` template option. + timeseries_rms.read_template2inps(): pass `no/False` values from `mintpy.residualRMS.maskFile/deramp/cutoff` template options to variables, as they are valid inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
utils.utils1.get_residual_std/rms():
rms_timeseriesResidual_ramp.txtwhen it should #969.ramp_typesame asnovalue, while determining the output file name frommintpy.residualRMS.deramptemplate option.timeseries_rms.read_template2inps(): pass
no/Falsevalues frommintpy.residualRMS.maskFile/deramp/cutofftemplate options to variables, as they are valid inputs.Reminders