Skip to content

deps: drop defusedxml#915

Merged
yunjunz merged 4 commits intoinsarlab:mainfrom
yunjunz:xml
Nov 23, 2022
Merged

deps: drop defusedxml#915
yunjunz merged 4 commits intoinsarlab:mainfrom
yunjunz:xml

Conversation

@yunjunz
Copy link
Member

@yunjunz yunjunz commented Nov 23, 2022

Description of proposed changes

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

revert back the ElementTree usage from `defusedxml` to the native `xml.etree` module, to drop this extra dependency, because there are only two use cases in the code: parse known XML files from ISCE and SNAP. insarlab#340
@yunjunz yunjunz merged commit 143fef5 into insarlab:main Nov 23, 2022
@yunjunz yunjunz deleted the xml branch November 23, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant