dem_error w/ phase velocity: rm all-zero column in design matrix#905
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Nov 12, 2022
Merged
dem_error w/ phase velocity: rm all-zero column in design matrix#905yunjunz merged 2 commits intoinsarlab:mainfrom
dem_error w/ phase velocity: rm all-zero column in design matrix#905yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
+ dem_error.py --phase-velocity: remove the all-zero column in the design matrix G and the all-one column in the design matrix G0, as the constant intercept term is not estimated in the phase velocity minimization scenario. Including this all-zero column in G could sometimes introduce abnormally large eigenvalues in the least-squares inversion, resulting in unrealistic TS residual.
mirzaees
approved these changes
Nov 11, 2022
Collaborator
mirzaees
left a comment
There was a problem hiding this comment.
Thank you @yunjunz! It looks good.
The only point that we should not forget is that timeseries residuals in line 266 lacks a constant if using phase velocity and results large residuals, hence not reliable.
It will be resolved after moving this part to velocity estimation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
dem_error.py --phase-velocity: remove the all-zero column in the design matrixGand the all-one column in the design matrixG0, as suggested by @mirzaees in abnormal large residual fromdem_errorfortimeseries_rms#892. This is because the constant intercept term of the polynomial is not estimated in the phase velocity minimization scenario. Including this all-zero column inGcould sometimes introduce abnormally large eigenvalues in the least-squares inversion, resulting in an unrealistic TS residual.Reminders