get_design_matrix4time_func(): bugfix for poly_order = 0#754
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Mar 19, 2022
Merged
get_design_matrix4time_func(): bugfix for poly_order = 0#754yunjunz merged 2 commits intoinsarlab:mainfrom
poly_order = 0#754yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
Resolves a bug which creates design matrices with columns of zeros
|
💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖 |
poly_order = 0
yunjunz
approved these changes
Mar 19, 2022
Member
yunjunz
left a comment
There was a problem hiding this comment.
LGTM, thank you @zhurewitz for the bug fix!
|
🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a bug which creates design matrices with columns of zeros