image_stitch - bugfix for bool / integer matrix#751
Merged
Conversation
Currently `image_stitch.py` can't correctly merge mask files. It puts the merged arrays into an array initialised as `np.nan`. Nans evaluate to `True`, meaning that we are left with blocks outside the data region that are set to `True`. Adding a simple check to see if we're merging boolean arrays, then setting the default values to `False` seems to fix the issue. Am I missing a possible bug here?
+ explicitly define "fill_value" variable + use vprint() to shorten the print() if check
yunjunz
approved these changes
Mar 18, 2022
Member
There was a problem hiding this comment.
Good catch @olliestephenson. This is a bug, for both boolean and integer types of the input matrix. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
image_stitch.pycan't correctly merge mask files. It puts the merged arrays into an array initialised asnp.nan. Nans evaluate toTrue, meaning that we are left with blocks outside the data region that are set toTrue. Adding a simple check to see if we're merging boolean arrays, then setting the default values toFalseseems to fix the issue. Am I missing a possible bug here?