bugfix: timeseries2velocity --save-res excluded dates#746
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Feb 14, 2022
Merged
bugfix: timeseries2velocity --save-res excluded dates#746yunjunz merged 2 commits intoinsarlab:mainfrom
--save-res excluded dates#746yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
Save timeseries_res: instantiate the output hdf5 file accounting for the excluded dates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bugfix for issue #739, which was brought up by @olliestephenson.
When saving time-series residuals during
timeseries2velocity.py, the code did not ignore the excluded dates. It writes residuals for all the dates we haven't excluded, leaving the final N date entries empty (where N is the number of dates we have excluded). This means that the residuals no longer line up with the correct dates.Now the code instantiates the output time-series residual hdf5 file with the correct number of dates, accounting for the excluded dates.
This bugfix is a realization of the suggested solution from @olliestephenson, in which we pass the shape of the timeseries with the excluded dates removed to
layout_hdf5via theds_name_dictargument.Co-authored by @yunjunz
Description of proposed changes
Reminders