Skip to content

fix bool array index bug for h5py>=3#743

Merged
yunjunz merged 4 commits intoinsarlab:mainfrom
bbuzzanga:bb_slicing1
Feb 10, 2022
Merged

fix bool array index bug for h5py>=3#743
yunjunz merged 4 commits intoinsarlab:mainfrom
bbuzzanga:bb_slicing1

Conversation

@bbuzzanga
Copy link
Contributor

@bbuzzanga bbuzzanga commented Feb 10, 2022

fix #741 (based on #470)

not thoroughly tested.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.

@bbuzzanga bbuzzanga changed the title Bb slicing1 fix bool array index bug Feb 10, 2022
@yunjunz yunjunz changed the title fix bool array index bug fix bool array index bug for h5py>=3 Feb 10, 2022
@yunjunz yunjunz self-requested a review February 10, 2022 05:12
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @bbuzz31 for the PR!

@yunjunz yunjunz merged commit 80df178 into insarlab:main Feb 10, 2022
@bbuzzanga bbuzzanga deleted the bb_slicing1 branch July 6, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indexing arrays must have integer dtypes

2 participants