closure_phase_bias.py - mask for areas susceptible to closure phase bias#740
closure_phase_bias.py - mask for areas susceptible to closure phase bias#740yunjunz merged 15 commits intoinsarlab:mainfrom
Conversation
Create a mask for areas susceptible to closure phase bias.
|
💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖 |
hfattahi
left a comment
There was a problem hiding this comment.
Thank you @yjzhenglamarmota for this interesting PR. This is going to be a very useful addition to mintpy. I have put in some comments mainly to clarify different things. It would be also nice to update the description of the PR with some example figures of the outputs.
Create a mask for areas susceptible to closure phase bias.
+ rename the script to closure_phase_bias.py, so that we could add the bias correction to this same script in the future as well. The usage could be similar to unwrap_error_phase_closure.py as below:
- closure_phase_bias.py --action mask
- closure_phase_bias.py --action correct
+ REFERENCE and EXAMPLE
+ address part of the comments from Heresh.
736ec60 to
7d7a879
Compare
Updated the code following Heresh and Yunjun's comments. Changed code name
…ta/MintPy into closurePhase_bias
hfattahi
left a comment
There was a problem hiding this comment.
Thanks @yjzhenglamarmota for addressing my comments. It looks good to me.
Create a mask for areas susceptible to closure phase bias.
Updated the code following Heresh and Yunjun's comments. Changed code name
Create a mask for areas susceptible to closure phase bias.
+ rename the script to closure_phase_bias.py, so that we could add the bias correction to this same script in the future as well. The usage could be similar to unwrap_error_phase_closure.py as below:
- closure_phase_bias.py --action mask
- closure_phase_bias.py --action correct
+ REFERENCE and EXAMPLE
+ address part of the comments from Heresh.
Addressing Heresh's comment on the input phase threshold. Changed to number of standard deviations of a Gaussian distribution (assumed distribution for the cumulative closure phase). Made the help message clearer.
…ta/MintPy into closurePhase_bias
Removed unused imported modules
af1dc7f to
0d6f925
Compare
deleted main_trackchange.tex
yunjunz
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you @yjzhenglamarmota.
Below is my test on Sierra Negra volcano in Galapagos (zenodo):
|
🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉 |
Description of proposed changes
Create a mask for areas susceptible to closure phase bias.
I added a standalone script - creatmask_cp.py - to enable creation of a mask that identifies areas susceptible to closure phase bias.