Skip to content

save_kite.py - convert to meters for UNIT in radians#738

Merged
yunjunz merged 37 commits intoinsarlab:mainfrom
mgovorcin:main
Feb 10, 2022
Merged

save_kite.py - convert to meters for UNIT in radians#738
yunjunz merged 37 commits intoinsarlab:mainfrom
mgovorcin:main

Conversation

@mgovorcin
Copy link
Contributor

@mgovorcin mgovorcin commented Feb 4, 2022

Description of proposed changes

save_kite.py - minor fixes for: 1) if .unw is used as input, 2) if input file UNIT is radian, convert to meters

coherenceCD.py - very simple script that generates a coherence change map as a difference between the average of coherence stack before the event (earthquake, vulcano eruption itd..) and average of coherence stack covering the event.
Below is the example for the Fernandina test dataset (vulcano eruption Sep 2017)

Screen Shot 2022-02-03 at 9 32 59 PM

Please see if you find it useful

Reminders

  • Fix #xxxx
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Marin Govorcin and others added 30 commits February 5, 2021 13:45
+ add mintpy banner
+ add details usage for mintpy2kite()
+ fix typo of attr['length']
+ break long lines of print()
+ use CENTER_LINE_UTC to replace stopUTC as the later is available for ISCE products only
+ add more comments on using velocity file as input

+ support geocoded ifgramStack file as input

+ grab date1/2 all the time
It's not consistent in the code (which should be corrected for consistency sometime in the futuree) and can be YYMMDD-YYMMDD or YYYYMMDD_YYYYMMDD.
Fixed option to export unwrapped interferograms from mintpy to kite format
@yunjunz
Copy link
Member

yunjunz commented Feb 6, 2022

Thank you @mgovorcin for maintaining save_kite.py.

Regarding coherenceCD.py, it's a great demonstration of using mintpy as a python module for customized work! I think it fits better as an example notebook on MintPy-tutorial repo, rather than an executable script within mintpy, because this procedure is not a standard processing step, nor it is peer-reviewed in publications (correct me on this if I am wrong please), plus we are moving mintpy toward a direction with less executable scripts, and more modules/functions in python level as APIs.

I would suggest keeping this PR for save_kite.py fixing only, and converting the coherenceCD.py into a jupyter notebook for a PR in mintpy-tutorial if you like.

@mgovorcin
Copy link
Contributor Author

Thank you @yunjunz for your comment on coherenceCD.py, I will gladly convert this script to an example jupyter notebok and submit it to MintPy-tutorial repo. Hope some people might find it useful

@mgovorcin mgovorcin changed the title Coherence Change Detection from ifgramStack.h5 save_kite.py - minor fixes Feb 10, 2022
resample: bugfix for auto_lat_lon_step_size() via merged src/lut_meta…
@yunjunz yunjunz changed the title save_kite.py - minor fixes save_kite.py - convert to meters for UNIT in radians Feb 10, 2022
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @mgovorcin.

@yunjunz yunjunz merged commit 2acac3f into insarlab:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants