Skip to content

prep_fringe: write ifgramStack for connected components#735

Merged
yunjunz merged 21 commits intoinsarlab:mainfrom
bbuzzanga:bb_fringeup
Feb 10, 2022
Merged

prep_fringe: write ifgramStack for connected components#735
yunjunz merged 21 commits intoinsarlab:mainfrom
bbuzzanga:bb_fringeup

Conversation

@bbuzzanga
Copy link
Contributor

@bbuzzanga bbuzzanga commented Feb 1, 2022

Description of proposed changes

Here a few updates for prep_fringe.

  • you can specify the input argument --geom-only to only write out geometry files (useful for making masks)
  • you can specify looks (this is only for tracking metadata)
  • if it can find connected component files, it will make ifgramStack.h5.
    • it will find them as long as they're the same names as the unwrapped interograms (required input) except with .conncomp extension

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@yunjunz yunjunz self-requested a review February 2, 2022 00:28
@yunjunz
Copy link
Member

yunjunz commented Feb 3, 2022

The issue of h5py indexing has been listed here (#705). The current version should work if you install h5py<3.

I planned to wait for h5py fixing, but it does not seem to happen anytime soon (and we are already in h5py version 3.6 ...). If we are gonna use different logic for h5py indexing, as suggested here (h5py/h5py#1750), I would prefer we do it in another PR, for all the occurrences.

@yunjunz yunjunz changed the title Bb fringeup prep_fringe: write ifgramStack for connected components Feb 3, 2022
@bbuzzanga
Copy link
Contributor Author

bbuzzanga commented Feb 4, 2022

Regarding the first point about h5py indexing, I can remove the two commits that implement these and revert my h5py.

bbuzz31 and others added 5 commits February 3, 2022 17:23
This reverts commit 4988ef8.
For now, use h5py < 3.0
Move multilooking metadata inside prep_metadata function
Dont update deprecated metadata
Comment about geom dirname
Remove -x -y as input argument options for nlks
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing passed on my local example fringe dataset.

Thank you @bbuzz31 for the useful feature!

@yunjunz yunjunz merged commit 2499eeb into insarlab:main Feb 10, 2022
@bbuzzanga
Copy link
Contributor Author

Great! Probably not all that useful for anyone but me yet, but hopefully with a few more future PRs it will be :D

@bbuzzanga bbuzzanga deleted the bb_fringeup branch July 6, 2022 15:42
@bbuzzanga bbuzzanga restored the bb_fringeup branch July 6, 2022 15:42
@bbuzzanga bbuzzanga deleted the bb_fringeup branch July 6, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants