prep_fringe: write ifgramStack for connected components#735
Merged
yunjunz merged 21 commits intoinsarlab:mainfrom Feb 10, 2022
Merged
prep_fringe: write ifgramStack for connected components#735yunjunz merged 21 commits intoinsarlab:mainfrom
yunjunz merged 21 commits intoinsarlab:mainfrom
Conversation
Sometimes (!) numpy raises an error when trying to slice with an array of bools. This implements a simple work around to catch it and slice with integers instead.
Member
|
The issue of h5py indexing has been listed here (#705). The current version should work if you install I planned to wait for h5py fixing, but it does not seem to happen anytime soon (and we are already in h5py version 3.6 ...). If we are gonna use different logic for h5py indexing, as suggested here (h5py/h5py#1750), I would prefer we do it in another PR, for all the occurrences. |
yunjunz
reviewed
Feb 3, 2022
yunjunz
reviewed
Feb 3, 2022
yunjunz
reviewed
Feb 3, 2022
yunjunz
reviewed
Feb 3, 2022
Contributor
Author
|
Regarding the first point about h5py indexing, I can remove the two commits that implement these and revert my h5py. |
yunjunz
reviewed
Feb 4, 2022
yunjunz
reviewed
Feb 4, 2022
Contributor
Author
|
Great! Probably not all that useful for anyone but me yet, but hopefully with a few more future PRs it will be :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Here a few updates for
prep_fringe.--geom-onlyto only write out geometry files (useful for making masks)ifgramStack.h5..conncompextensionReminders