generic multi-dataset file (e.g. velocity) support in add/diff/deramp#732
generic multi-dataset file (e.g. velocity) support in add/diff/deramp#732yunjunz merged 7 commits intoinsarlab:mainfrom
add/diff/deramp#732Conversation
e782c79 to
74f13a8
Compare
yunjunz
left a comment
There was a problem hiding this comment.
Thank you @yuankailiu for the useful PR. Could we use the existing else block by assigning dsName or datasetName for the velocity file type, for this functionality, instead of creating a new elif block of code? That would be a more adaptable solution.
74f13a8 to
cce7df1
Compare
|
Hi @yuankailiu, thank you for addressing the suggestion. We should apply the same style of changes in |
+ add.py: when operating on velocity files, operate on velocity dset as default + diff.py: when operating on velocity files, operate on velocity dset as default + utils1..py: when deramping on velocity files, operate on velocity dset as default
cce7df1 to
2dde2d5
Compare
A more general change based on the previous commit + add.py: when input files have multiple datasets, operate on the common dataset(s) + diff.py: when input files have multiple datasets, operate on the common dataset(s)
2dde2d5 to
9f58112
Compare
@yunjunz, for So now Do you think this is a good way to go? |
|
Hi @yuankailiu, that is a good idea. |
e.g. mask, mask, waterMask. This is done by 1) use the 1st file ds name as reference, and 2) ignore ds name for the rest file
add/diff/deramp
Description of proposed changes
Here propose to operate on the velocity dataset as default when using the following functions/codes on the velocity files (
FILE_TYPE=velocity)Before, the default for deramping is operating on the first dataset, not necessarily the "velocity" if there are multiple fields in it, e.g., "annualAmplitude".
Also the same situation in
add.pyanddiff.py.This is a quick tweak, it would be even better to allow a user-defined
datasetwhen calling the function, which could be in another PR.Thanks for reviewing it.
Reminders