Skip to content

image_stitch: bugfix & update plotting#730

Merged
yunjunz merged 3 commits intomainfrom
olliestephenson-patch-1
Jan 26, 2022
Merged

image_stitch: bugfix & update plotting#730
yunjunz merged 3 commits intomainfrom
olliestephenson-patch-1

Conversation

@olliestephenson
Copy link
Contributor

@olliestephenson olliestephenson commented Jan 26, 2022

Description of proposed changes

fig is used as a variable for the whole figure, and then each of the subplots. This mean that fig.savefig results in the error AttributeError: 'AxesSubplot' object has no attribute 'savefig'

Removed fig= on the subplot lines

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

olliestephenson and others added 2 commits January 25, 2022 19:00
`fig` is used as a variable for the whole figure, and then each of the subplots. This mean that `fig.savefig` results in the error `AttributeError: 'AxesSubplot' object has no attribute 'savefig'`
+ shares x/y-axis tick labels
+ share a common colorbar and vmin/max
+ auto figsize via pp.auto_figure_size()
+ add interpolation='nearest' to imshow()
+ auto vmin/max via multilook_data()
@yunjunz yunjunz self-requested a review January 26, 2022 04:28
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the bug report and fix @olliestephenson.

Since we are here, I update the plot code to the latest styles. Cheers.

@yunjunz yunjunz changed the title Plotting issue in image_stitch.py image_stitch: bugfix & update plotting Jan 26, 2022
@yunjunz yunjunz merged commit cfa7991 into main Jan 26, 2022
@yunjunz yunjunz deleted the olliestephenson-patch-1 branch January 26, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants