Skip to content

update installation note, env setup and circle-ci testing#700

Merged
yunjunz merged 12 commits intoinsarlab:mainfrom
jhkennedy:reqs
Nov 21, 2021
Merged

update installation note, env setup and circle-ci testing#700
yunjunz merged 12 commits intoinsarlab:mainfrom
jhkennedy:reqs

Conversation

@jhkennedy
Copy link
Collaborator

@jhkennedy jhkennedy commented Nov 19, 2021

Since #659 , there's no longer a need to manipulate PATH or PYTHONPATH as a pip install will correctly place the mintpy package and all executable scripts to be available in the environment.

Additionally, PyPAS and PySolid are available via conda-forge and no longer need to be cloned and manually built/installed.

Draft because I need to do docs yet

Reminders

  • Fix #xxxx
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@jhkennedy jhkennedy requested a review from yunjunz November 19, 2021 01:33
@yunjunz
Copy link
Member

yunjunz commented Nov 19, 2021

It's great that the conda install pysolid and pyaps3 is fully working! Thank you @jhkennedy!

I could help with the doc updates, will try it this weekend.

@jhkennedy
Copy link
Collaborator Author

@yunjunz I took a first stab at the documentation updates. conda install should be the same on any platform now, so I removed the windows install note.

Also, I've update the pip commands to use the preferred python -m pip invocation (long discussion at pypa/pip#3164), except for macports because I'm don't use a mac. I suspect for macports you'd also just do a sudo -H python3 -m pip.

I'm off to a cabin for the weekend tomorrow, so feel free to run with this, or I'll be back to iterate on Monday. 😄

@jhkennedy jhkennedy marked this pull request as ready for review November 19, 2021 07:01
@yunjunz yunjunz changed the title Update environment setup and circle-ci testing update installation note, env setup and circle-ci testing Nov 20, 2021
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me now!

For the macports part, since I don't use macports actively anymore, I did not change the previous pip install style.

@yunjunz yunjunz merged commit 2fb0a7d into insarlab:main Nov 21, 2021
@jhkennedy jhkennedy deleted the reqs branch November 22, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants