coord.lalo2yx(): replace np.float128 with np.longdouble for Windows#699
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Nov 18, 2021
Merged
coord.lalo2yx(): replace np.float128 with np.longdouble for Windows#699yunjunz merged 2 commits intoinsarlab:mainfrom
yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
Contributor
Author
|
Hmm something is wrong on CircleCI during the installation process (timed out)? I don't think it's related to the code I changed. |
yunjunz
approved these changes
Nov 18, 2021
Member
yunjunz
left a comment
There was a problem hiding this comment.
LGTM. Thank you @pbrotoisworo for the fix.
You are right: there is an issue with circle CI at the moment, it's not related to your change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Simple change that modifies
np.float128object tonp.longdouble. This is because float128 is not supported on Windows OS and will raise errors for Windows users.Reminders