Up to date version of the image can be found at forrestwilliams/mintpy:1.3.1

@forrestfwilliams this is great!

I was able to build this image and run the tests inside it just fine, like:

docker run -it forrestwilliams/mintpy:1.3.1
cd tools/MintPy/tests
micromamba install -c conda-forge wget  # needed for test
python test_smallbaselineApp.py

So in terms of the dockerfile, I'd call this g2g! (unless it's worth adding wget to the apt-get install as well)

@yunjunz, I assume you'd like to do the final approval?

Other thoughts for you @forrestfwilliams and @yunjunz:

• in docker.md and installation.md, the andretheronsa/mintpy:latest image is referenced, but it hasn't been updated in two years:
  https://hub.docker.com/r/andretheronsa/mintpy
  I'd say it's worth updating to @forrestfwilliams image

Edit: Moved 2nd point to #123.

Good point @jhkennedy. Let's update the docker image's link in the two *.md files to forrestwilliams/mintpy, could you please do that @forrestfwilliams?

I tried to test the docker image following the same command as @jhkennedy wrote above. It passed the first two datasets for (ISCE and ARIA) and failed at generating KMZ file for the GAMMA dataset, as shown in the error message below. Manually running the save_kmz.py command works fine actually. Any idea why?

******************** step - google_earth ********************
creating Google Earth KMZ file for geocoded velocity file: ...

save_kmz.py /home/micromamba/data/test/WellsEnvD2T399/mintpy/geo/geo_velocity.h5 -o /home/micromamba/data/test/WellsEnvD2T399/mintpy/geo/geo_velocity.kmz
data   coverage in y/x: (0, 0, 753, 537)
subset coverage in y/x: (0, 0, 753, 537)
update LENGTH, WIDTH, Y/XMAX
update/add SUBSET_XMIN/YMIN/XMAX/YMAX: 90/12/843/549
update Y/X_FIRST
update REF_Y/X
read mask from file: geo_maskTempCoh.h5
masking out pixels with zero value in file: None
colormap: jet
plotting data ...
figure size : [16.83, 12.00]
show reference point
writing /home/micromamba/data/test/WellsEnvD2T399/mintpy/geo/geo_velocity.png with dpi=600
Killed
Traceback (most recent call last):
  File "test_smallbaselineApp.py", line 209, in <module>
    main(sys.argv[1:])
  File "test_smallbaselineApp.py", line 190, in main
    test_isce=inps.test_isce)
  File "test_smallbaselineApp.py", line 153, in test_dataset
    raise RuntimeError('Test failed for example dataset {}'.format(dset_name))
RuntimeError: Test failed for example dataset WellsEnvD2T399

@yunjunz the Killed in the line makes me suspect a memory issue (hitting a docker imposed limit?) -- I was able to run all of them through on my linux box.

@jhkennedy you are right. After increasing the resource limit for Docker from the default values, all tests passed for me as well.

Morning! I'll go ahead and make these changes:

• add wget
• update installation.md and docker.md

@yunjunz, for PYAPS_HOME and MINTPY_HOME are you saying the user doesn't need to access them once MintPy is built? If so, I might go ahead and hard-code them.

@forrestfwilliams yes, users do not need to access the two variables.

I've updated the dockerfile/docs. I also ran the tests in a container built from the new image and all tests passed! I'm re-uploading the image to docker and I'll let you know when it's done.

New build is available at forrestwilliams/mintpy:1.3.1 !

Oops sorry I missed these

No worries at all.

I am not a regular user of docker. @forrestfwilliams could you confirm if my modification of using ARG MINTPY_HOME and PYAPS_HOME in the DockerFile is reasonable?

@yunjunz, I'd like to get @jhkennedy's opinion on this but my understanding is that ARGs should be reserved for variables that we want to be modifiable by someone building the image (see here). Your modifications improve readability, but I'm not sure if we want the MINTPY_HOME and PYAPS_HOME locations to be modifiable. Thoughts?

The PR is ready to merge in my opinion. @forrestfwilliams please feel free to merge it if you think it's ready.

Thanks @yunjunz ! I think we're ready to merge as well but I'm not sure I have the permissions to do so.

I just sent you an invite. Could you try again after acceptance?

Merged! Thanks for inviting me to join insarlab!

Great to have you here!