__init__: rm sys.path.insert() and force internal imports#653
Merged
yunjunz merged 3 commits intoinsarlab:mainfrom Sep 1, 2021
Merged
__init__: rm sys.path.insert() and force internal imports#653yunjunz merged 3 commits intoinsarlab:mainfrom
sys.path.insert() and force internal imports#653yunjunz merged 3 commits intoinsarlab:mainfrom
Conversation
+ mintpy/__inti__.py: remove try/except for print and MINTPY_HOME as it's not used anywhere + test_smallbaselineApp.py: - use relative path to locate config file, instead of using mintpy module - remove the occrrence of MINTPY_HOME - remove print view.py cmd as it's now included inside view.py if --noverbose is turned ON
jhkennedy
requested changes
Sep 1, 2021
Collaborator
jhkennedy
left a comment
There was a problem hiding this comment.
Looks great! Just one real change I'd suggest (TEMPLATE_FILES) and another structure suggestion (namespace) you can feel free to take or leave.
+ mintpy/__inti__.py: remove `sys.path.insert()` calls. This was a replicate of the isce-2 syle (isceobj, iscesys, etc.), but it is not really applicable and used in mintpy. + test_sbApp: use `pathlib.Path().resolve()` instead of `os.path.dirname()`
sys.path.insert() and force all internal imports
sys.path.insert() and force all internal importssys.path.insert() and force internal imports
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR address the 1st and 2nd issues in #652.
mintpy/__inti__.py:sys.path.insert()calls. These were replicates from the isce-2 style (isceobj, iscesys, etc.), but they are not really applicable to and used in mintpy, nor had we encouraged in any other files besides this one.NOTE: however, this might still potentially impact downstream workflows, thus, should be noted in the release notes/changelog.
Reminders