Triplet design matrix speedup#650
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Aug 28, 2021
scottstanie:triplet-matrix-speedup
Merged
Triplet design matrix speedup#650yunjunz merged 2 commits intoinsarlab:mainfrom scottstanie:triplet-matrix-speedup
yunjunz merged 2 commits intoinsarlab:mainfrom
scottstanie:triplet-matrix-speedup
Conversation
yunjunz
approved these changes
Aug 28, 2021
Member
yunjunz
left a comment
There was a problem hiding this comment.
Looks great, thank you @scottstanie!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Speeds up the creation of the closure phase matrix in
ifgramStack.get_design_matrix4triplet(discussed in #649). Should result in same output as previous implementationReminders
get_design_matrix4triplet? #649