asc_desc2horz_vert: bugfix on custom azimuth and refactor#636
Merged
yunjunz merged 4 commits intoinsarlab:mainfrom Aug 10, 2021
Merged
asc_desc2horz_vert: bugfix on custom azimuth and refactor#636yunjunz merged 4 commits intoinsarlab:mainfrom
yunjunz merged 4 commits intoinsarlab:mainfrom
Conversation
The azimuth variable is supplied as part of the command line input, however it's not actually passed to the `get_design_matrix` function where its needed, meaning the command line variable does nothing and the azimuth angle defaults to 90 degrees. I've added code to pass it through to the design matrix function, so now the azimuth angle can be modified via the command line.
Member
|
The bug was introduced in #230. Thank you @olliestephenson for finding it out and fixing it! |
+ use `azimuth` for the direction of interest throughout the script + use `los_az_angle` for the direction of LOS vector throughout the script, and to replace `head_angle` to be consistent with the rest of mintpy + update comments accordingly.
Member
|
I find my notations in the script are not very clear, so I refactor them here. Below is the notebook I used for testing: |
Member
|
For anyone who might be interested or concerned, the version before this PR works fine with the default azimuth direction. So I don't expect any impact if you did not specify an azimuth angle in the command line. |
Member
|
Hi @olliestephenson, please note that I change the input azimuth angle definition to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The azimuth variable is supplied as part of the command line input, however it's not actually passed to the
get_design_matrixfunction where its needed, meaning the command line variable does nothing and the azimuth angle defaults to 90 degrees. I've added code to pass it through to the design matrix function, so now the azimuth angle can be modified via the command line.