asc_desc2horz_vert.py --oo: Avoid overwriting modified attributes#635
Merged
yunjunz merged 1 commit intoinsarlab:mainfrom Aug 10, 2021
Merged
asc_desc2horz_vert.py --oo: Avoid overwriting modified attributes#635yunjunz merged 1 commit intoinsarlab:mainfrom
yunjunz merged 1 commit intoinsarlab:mainfrom
Conversation
Currently the file attributes are modified in the `asc_desc_files2horz_vert` function to take account of the fact that we're looking at the overlap between two tracks. However the `write_to_one_file` as currently written overwrites the input `atr` variable when looping over the list of attributes for the input files. The least to the attributes of the newly created file being incorrect.
yunjunz
approved these changes
Aug 10, 2021
Member
yunjunz
left a comment
There was a problem hiding this comment.
Good catch! Thank you @olliestephenson.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Currently the file attributes are modified in the
asc_desc_files2horz_vertfunction to take account of the fact that we're looking at the overlap between two tracks. However thewrite_to_one_fileas currently written overwrites the inputatrvariable when looping over the list of attributes for the input files. The least to the attributes of the newly created file being incorrect. I've proposed a renaming to avoid this.