asc_desc2horz_vert --oo: grab sensor name from PROJECT_NAME#634
Merged
yunjunz merged 1 commit intoinsarlab:mainfrom Aug 10, 2021
Merged
asc_desc2horz_vert --oo: grab sensor name from PROJECT_NAME#634yunjunz merged 1 commit intoinsarlab:mainfrom
yunjunz merged 1 commit intoinsarlab:mainfrom
Conversation
yunjunz
approved these changes
Aug 10, 2021
Member
yunjunz
left a comment
There was a problem hiding this comment.
By default, PROJECT_NAME is grabbed from FILE_PATH or template file name in load_data.py. However, one could manually add/modify PROJECT_NAME afterward. So I agree with you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Passing the project name, rather than the file path, to project_name2sensor_name seems like a more reliable way of getting the sensor name.