ts2vel: skip writing for empty blocks#624
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom Aug 2, 2021
Merged
Conversation
write_hdf5_block function comes from the writefile import
Contributor
Author
|
I've realised that the write_hdf5_block function from writefile needs different arguments, so my bug fix isn't valid |
Member
|
yeah, it is from an older version of timeseries2velocity.py which has its own layout_hdf5/write_hdf5_block(). The bug is still valid. Thank you for pointing this out. It turns out that we don't need to write for empty blocks at all, since the file has been initiated with default values. |
yunjunz
approved these changes
Aug 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fixing a minor bug - write_hdf5_block function comes from the writefile import