Skip to content

read_attr: check existing FILE_TYPE for HDF5 file#615

Merged
yunjunz merged 3 commits intoinsarlab:mainfrom
mirzaees:FILE_TYPE_check
Jul 25, 2021
Merged

read_attr: check existing FILE_TYPE for HDF5 file#615
yunjunz merged 3 commits intoinsarlab:mainfrom
mirzaees:FILE_TYPE_check

Conversation

@mirzaees
Copy link
Collaborator

@mirzaees mirzaees commented Jul 25, 2021

Description of proposed changes

When I run info.py, the "FILE_TYPE" is guessed based on dataset name and if a stack with different naming is called, some options like --date do not work.
This change proposes to read 'FILT_TYPE' from the stack attributes if exists.

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

@mirzaees mirzaees requested a review from yunjunz July 25, 2021 01:45
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @mirzaees.

@yunjunz yunjunz changed the title check for file type in metadata read_attr: check existing FILE_TYPE for HDF5 file Jul 25, 2021
@yunjunz yunjunz merged commit 11bed8d into insarlab:main Jul 25, 2021
@mirzaees mirzaees deleted the FILE_TYPE_check branch June 29, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants