sensor: add TeLEOS-2 & update TSX/SeaSat/HJ1C/ALOS4#1424
Merged
yunjunz merged 1 commit intoinsarlab:mainfrom Oct 11, 2025
Merged
sensor: add TeLEOS-2 & update TSX/SeaSat/HJ1C/ALOS4#1424yunjunz merged 1 commit intoinsarlab:mainfrom
sensor: add TeLEOS-2 & update TSX/SeaSat/HJ1C/ALOS4#1424yunjunz merged 1 commit intoinsarlab:mainfrom
Conversation
+ add sensor/platform parameters of TeLEOS-2 + HJ1C: add antenna size + TSX: update antenna size based on more accurate reference. + SeaSat: add NESZ from Curlander & Mcdonough (1991) + ALOS4: add antenna_length/width
Contributor
Reviewer's GuideThe PR extends sensor metadata in src/mintpy/objects/sensor.py by introducing a new TeleOS-2 definition and refining existing sensor entries—TSX, GF3, HJ1C, SeaSat, and ALOS4—through updated antenna dimensions, added noise-equivalent sigma zero values, improved parameter precision, and appended literature references. Entity relationship diagram for updated sensor data structureserDiagram
TSX {
float altitude
float orbit_inclination
int repeat_cycle
float carrier_frequency
float antenna_length
float antenna_width
float doppler_bandwidth
float pulse_repetition_frequency
float chirp_bandwidth
}
TELEOS2 {
float altitude
float orbit_inclination
}
GF3 {
float altitude
float orbit_inclination
float carrier_frequency
float antenna_length
float antenna_width
float pulse_repetition_frequency
float chirp_bandwidth
float sampling_frequency
}
HJ1C {
float altitude
float orbit_inclination
int repeat_cycle
float carrier_frequency
float antenna_length
float antenna_width
float pulse_repetition_frequency
float chirp_bandwidth
float noise_equivalent_sigma_zero
}
SEASAT {
float altitude
float orbit_inclination
float carrier_frequency
float antenna_length
float antenna_width
float pulse_repetition_frequency
float chirp_bandwidth
float noise_equivalent_sigma_zero
}
ALOS4 {
float altitude
float orbit_inclination
int repeat_cycle
float carrier_frequency
float antenna_length
float antenna_width
float chirp_bandwidth
float range_resolution
float noise_equivalent_sigma_zero
}
Class diagram for updated sensor metadata definitionsclassDiagram
class TSX {
altitude: float
orbit_inclination: float
repeat_cycle: int
carrier_frequency: float
antenna_length: float (updated)
antenna_width: float (updated)
doppler_bandwidth: float
pulse_repetition_frequency: float
chirp_bandwidth: float
}
class TELEOS2 {
altitude: float (new)
orbit_inclination: float (new)
}
class GF3 {
altitude: float
orbit_inclination: float
carrier_frequency: float
antenna_length: float
antenna_width: float (updated)
pulse_repetition_frequency: float
chirp_bandwidth: float
sampling_frequency: float
}
class HJ1C {
altitude: float
orbit_inclination: float (updated)
repeat_cycle: int
carrier_frequency: float
antenna_length: float (new)
antenna_width: float (new)
pulse_repetition_frequency: float
chirp_bandwidth: float
noise_equivalent_sigma_zero: float (updated)
}
class SEASAT {
altitude: float
orbit_inclination: float
carrier_frequency: float
antenna_length: float
antenna_width: float
pulse_repetition_frequency: float
chirp_bandwidth: float
noise_equivalent_sigma_zero: float (new)
}
class ALOS4 {
altitude: float
orbit_inclination: float
repeat_cycle: int
carrier_frequency: float
antenna_length: float (new)
antenna_width: float (new)
chirp_bandwidth: float
range_resolution: float
noise_equivalent_sigma_zero: float
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The TELEOS2 dictionary currently only defines altitude and inclination; please fill in the remaining SAR parameters (e.g., carrier_frequency, antenna dimensions, PRF, bandwidth, repeat_cycle) to match the format of other sensors.
- It may help to standardize all sensor entries with the same set of keys (even if some values are temporarily unknown) to avoid potential KeyErrors when accessing missing parameters.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The TELEOS2 dictionary currently only defines altitude and inclination; please fill in the remaining SAR parameters (e.g., carrier_frequency, antenna dimensions, PRF, bandwidth, repeat_cycle) to match the format of other sensors.
- It may help to standardize all sensor entries with the same set of keys (even if some values are temporarily unknown) to avoid potential KeyErrors when accessing missing parameters.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
add sensor/platform parameters of TeLEOS-2
HJ1C: add antenna size
TSX: update antenna size based on more accurate reference.
SeaSat: add NESZ from Curlander & Mcdonough (1991)
ALOS4: add antenna_length/width
Reminders