Skip to content

utils/plot: handle empty data in auto_adjust_colormap_lut_and_disp_limit()#1419

Merged
yunjunz merged 3 commits intoinsarlab:mainfrom
frx08:fix/auto-adjust-colormap
Nov 23, 2025
Merged

utils/plot: handle empty data in auto_adjust_colormap_lut_and_disp_limit()#1419
yunjunz merged 3 commits intoinsarlab:mainfrom
frx08:fix/auto-adjust-colormap

Conversation

@frx08
Copy link
Contributor

@frx08 frx08 commented Sep 23, 2025 •
edited by sourcery-ai bot
Loading

Description of proposed changes

Fix ValueError: zero-size array to reduction operation minimum in
auto_adjust_colormap_lut_and_disp_limit.

  • Handle the case where input data has no finite values.
  • Return neutral display limits [0.0, 0.0] and None LUT when no valid pixels are found.
  • Prevents crashes in view.py plotting when datasets are fully NaN/invalid.

Reminders

  • Fix #xxxx
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Summary by Sourcery

Handle empty or fully invalid data in auto_adjust_colormap_lut_and_disp_limit by returning default neutral display limits and None LUT instead of crashing

Bug Fixes:

  • Avoid ValueError from zero-size array reduction when no finite values are present

Enhancements:

  • Warn when no valid pixels are found and return display limits [0.0, 0.0] with a None LUT

@frx08
utils/plot: handle empty data in auto_adjust_colormap_lut_and_disp_limit
fc207f1 
Avoid ValueError when input has no finite values by returning neutral
display limits [0.0, 0.0] and None LUT. This prevents crashes in view.py
plotting when datasets are fully NaN or invalid.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 23, 2025 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates auto_adjust_colormap_lut_and_disp_limit to gracefully handle cases where the input data contains no finite values by early exiting with default display limits and prevents crashes by refactoring the way unique values are extracted.

File-Level Changes

Change Details Files
Introduce empty-data handling with default return
  • Mask invalid entries and create finite_values array
  • Check for zero-size finite_values
  • Print warning and return neutral limits [0.0, 0.0] with None LUT
 src/mintpy/utils/plot.py
Refactor unique value computation to use masked finite data
  • Replace direct NaN filtering with np.unique on finite_values
 src/mintpy/utils/plot.py

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@yunjunz
Copy link
Member

yunjunz commented Nov 23, 2025

I was able to reproduce the error you have as below, and your PR fixed it. Thank you @frx08!

colormap: jet
DESCENDING orbit -> flip left-right
figure title: velocity
figure size : [10.0, 6.0]
read mask from file: maskTest.h5
reading data ...
masking data
Traceback (most recent call last):
  File "/Users/yunjunz/tools/mambaforge/envs/insar/bin/view.py", line 8, in <module>
    sys.exit(main())
  File "/Users/yunjunz/tools/MintPy/src/mintpy/cli/view.py", line 186, in main
    obj.plot()
  File "/Users/yunjunz/tools/MintPy/src/mintpy/view.py", line 1675, in plot
    data, self = update_data_with_plot_inps(data, self.atr, self)
  File "/Users/yunjunz/tools/MintPy/src/mintpy/view.py", line 324, in update_data_with_plot_inps
    inps.unique_values) = pp.auto_adjust_colormap_lut_and_disp_limit(data, print_msg=inps.print_msg)
  File "/Users/yunjunz/tools/MintPy/src/mintpy/utils/plot.py", line 403, in auto_adjust_colormap_lut_and_disp_limit
    vstep = np.min(np.abs(np.diff(unique_values))).astype(float)
  File "<__array_function__ internals>", line 200, in amin
  File "/Users/yunjunz/tools/mambaforge/envs/insar/lib/python3.10/site-packages/numpy/core/fromnumeric.py", line 2946, in amin
    return _wrapreduction(a, np.minimum, 'min', axis, None, out,
  File "/Users/yunjunz/tools/mambaforge/envs/insar/lib/python3.10/site-packages/numpy/core/fromnumeric.py", line 84, in _wrapreduction
    return reduction(axis=axis, out=out, **passkwargs)
  File "/Users/yunjunz/tools/mambaforge/envs/insar/lib/python3.10/site-packages/numpy/ma/core.py", line 5804, in min
    result = self.filled(fill_value).min(
  File "/Users/yunjunz/tools/mambaforge/envs/insar/lib/python3.10/site-packages/numpy/core/_methods.py", line 45, in _amin
    return umr_minimum(a, axis, None, out, keepdims, initial, where)
ValueError: zero-size array to reduction operation minimum which has no identity

@yunjunz yunjunz changed the title utils/plot: handle empty data in auto_adjust_colormap_lut_and_disp_limit utils/plot: handle empty data in auto_adjust_colormap_lut_and_disp_limit() Nov 23, 2025
@yunjunz yunjunz merged commit 70ea111 into insarlab:main Nov 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@yunjunz yunjunz yunjunz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frx08 @yunjunz