Skip to content

objects/sensor: add SAOCOM support and fix carrier_frequency typo#1418

Merged
yunjunz merged 1 commit intoinsarlab:mainfrom
frx08:fix-saocom-sensor
Sep 28, 2025
Merged

objects/sensor: add SAOCOM support and fix carrier_frequency typo#1418
yunjunz merged 1 commit intoinsarlab:mainfrom
frx08:fix-saocom-sensor

Conversation

@frx08
Copy link
Contributor

@frx08 frx08 commented Sep 22, 2025

Description of proposed changes

Add SAOCOM sensor support:

  • Add name variations for SAOCOM (saocom, sao, saocom1a, saocom1b)
  • Map to UNAVCO mission name SAOCOM
  • Fix typo in carrier_frequency
  • Register SAOCOM in SENSOR_DICT

Reminders

  • Fix #xxxx
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Summary by Sourcery

Enable SAOCOM sensors by extending mapping rules, UNAVCO mission name conversion, and dictionary registration, and correct the carrier_frequency typo

New Features:

  • Add SAOCOM sensor support with name variations, UNAVCO mission mapping, and registration in SENSOR_DICT

Bug Fixes:

  • Fix typo in carrier_frequency key

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR integrates SAOCOM sensor support into the sensor module by registering its name variations, mapping it to the UNAVCO mission name, and adding it to the sensor dictionary, as well as correcting a typo in the SAR parameter key for carrier frequency.

Class diagram for updated sensor name mapping and SAOCOM addition

classDiagram
    class SENSOR_DICT {
    }
    class SAOCOM {
        orbit_inclination: float
        repeat_cycle: int
        carrier_frequency: float
        antenna_length: float
        pulse_repetition_frequency: int
        sampling_frequency: float
    }
    SENSOR_DICT <|-- SAOCOM
    class get_unavco_mission_name {
        +get_unavco_mission_name(meta_dict)
    }
    get_unavco_mission_name --> SAOCOM: maps to
Loading

Class diagram for SAR parameter key correction (carrier_frequency)

classDiagram
    class SAOCOM {
        carrier_frequency: float
    }
Loading

File-Level Changes

Change Details Files
Add SAOCOM sensor support
  • Define SAOCOM name variations list
  • Map SAOCOM in get_unavco_mission_name
  • Register SAOCOM in SENSOR_DICT
src/mintpy/objects/sensor.py
Fix carrier_frequency typo
  • Rename 'carrrier_frequency' key to 'carrier_frequency'
src/mintpy/objects/sensor.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @frx08!

@yunjunz yunjunz merged commit c31dfda into insarlab:main Sep 28, 2025
9 checks passed
@welcome
Copy link

welcome bot commented Sep 28, 2025

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants