sensor: add BIOMASS/SWOT/NISAR-S, and NESZ for several missions#1354
Merged
yunjunz merged 2 commits intoinsarlab:mainfrom May 31, 2025
Merged
sensor: add BIOMASS/SWOT/NISAR-S, and NESZ for several missions#1354yunjunz merged 2 commits intoinsarlab:mainfrom
sensor: add BIOMASS/SWOT/NISAR-S, and NESZ for several missions#1354yunjunz merged 2 commits intoinsarlab:mainfrom
Conversation
+ objects.sensor.py - add parameters for BIOMASS/SWOT/NISAR-S - add NESZ for several missions + more print out message for multilook.py and unwrap_error_phase_closure.py
Contributor
Reviewer's GuideThis PR extends the sensor definitions by introducing new missions (SWOT, NISAR-S, BIOMASS), enriches existing sensor metadata with NESZ values and updated parameters, and improves user feedback in the CLI by adding example flags in multilook.py and logging in unwrap_error_phase_closure.py. Class Diagram for New Sensor Definitions (SWOT, NISAR-S, BIOMASS)classDiagram
class SWOT {
+altitude: number
+orbit_inclination: number
+carrier_frequency: number
+pulse_repetition_frequency: number
+chirp_bandwidth: number
+sampling_frequency: number
}
class NISAR_S {
+altitude: number
+orbit_inclination: number
+repeat_cycle: number
+carrier_frequency: number
+antenna_radius: number
+pulse_repetition_frequency: number
+chirp_bandwidth: number
+azimuth_resolution: number
+noise_equivalent_sigma_zero: number
}
class BIOMASS {
+altitude: number
+orbit_inclination: number
+repeat_cycle: number
+carrier_frequency: number
+antenna_length: number
+pulse_repetition_frequency: number
+chirp_bandwidth: number
+range_pixel_size: number
+azimuth_pixel_size: number
+noise_equivalent_sigma_zero: number
}
Class Diagram: Updates to Sensor Configuration DictionariesclassDiagram
class SENSOR_DICT {
<<Dictionary>>
+String bio : BIOMASS <<added>>
%%
... other existing entries
}
class BIOMASS {
%% Defined in "New Sensor Definitions" diagram
%% Attributes: altitude, orbit_inclination, etc.
}
SENSOR_DICT o-- BIOMASS : "entry 'bio'"
class MISSION_ALIASES {
<<Dictionary>>
+String bio : List~String~ <<added>> %% Value: ["bio", "biomass"]
%%
... other existing entries
}
Class Diagram: Illustrative Updates to Existing Sensor ParametersclassDiagram
class RCM {
<<Sensor>>
+chirp_bandwidth: number <<added>>
+noise_equivalent_sigma_zero: number <<added>>
%%
... other existing attributes
}
class SEN {
<<Sensor>>
+antenna_width: number <<updated>>
+noise_equivalent_sigma_zero: number <<added>>
%%
... other existing attributes
}
class ALOS4 {
<<Sensor>>
+carrier_frequency: number <<added>>
+chirp_bandwidth: number <<added>>
+range_resolution: number <<added>>
+noise_equivalent_sigma_zero: number <<added>>
%%
... other existing attributes
}
class GF3 {
<<Sensor>>
+antenna_width: number <<updated>>
+noise_equivalent_sigma_zero: number <<added>>
%%
... other existing attributes
}
%% Other sensors updated primarily with 'noise_equivalent_sigma_zero':
%% - HJ1C, ALOS, ALOS2, SAOCOM, LT1, UAV_L, NISAR_L
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @yunjunz - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
objects.sensor.pymore print out message for
multilook.pyandunwrap_error_phase_closure.pyReminders